Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Material][Chip|ChipGroup] Add lightweight styling support for Chip/ChipGroup Material styles #597

Closed
kazo0 opened this issue Jun 7, 2023 · 0 comments · Fixed by #612
Closed

[Material][Chip|ChipGroup] Add lightweight styling support for Chip/ChipGroup Material styles #597

kazo0 opened this issue Jun 7, 2023 · 0 comments · Fixed by #612
Assignees
@nguyeenvy
Labels
control/chip-chipgroup kind/enhancement New feature or request. theme/material

Comments

@kazo0
Copy link
Contributor

kazo0 commented Jun 7, 2023

We should be defining lightweight styling resources for as many properties/brushes/visualstates as we can and define and use them in the Base Fluent style file (we need to create a Chip.xaml and ChipGroup.xaml in the base Uno.Toolkit.UI library

Then, we should be using them in the Material style templates for Chip and ChipGroup as well.
@kazo0 kazo0 added kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification. theme/material control/chip-chipgroup and removed triage/untriaged Indicates an issue requires triaging or verification. labels Jun 7, 2023
@nguyeenvy nguyeenvy self-assigned this Jun 7, 2023
@nguyeenvy nguyeenvy mentioned this issue Jun 14, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nguyeenvy nguyeenvy

Labels
control/chip-chipgroup kind/enhancement New feature or request. theme/material
Projects
None yet
Milestone
No milestone
2 participants
@kazo0 @nguyeenvy