Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ShadowContainer] Shadows are not repainted when the ShadowCollection is changed #805

Closed
kazo0 opened this issue Sep 3, 2023 · 1 comment · Fixed by #806, #808 or #809
Closed

[ShadowContainer] Shadows are not repainted when the ShadowCollection is changed #805

kazo0 opened this issue Sep 3, 2023 · 1 comment · Fixed by #806, #808 or #809
Assignees
@kazo0
Labels
control/shadows kind/bug Something isn't working

Comments

@kazo0
Copy link
Contributor

kazo0 commented Sep 3, 2023

Repro steps

  1. Launch Toolkit sample app
  2. Navigation to ShadowContainer sample page
  3. Remove Shadows from the Shadow Builder sample
  4. Notice the shadows remain drawn on the container

Investigation

It seems we are missing a call to InvalidateShadows() after this line
@kazo0 kazo0 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Sep 3, 2023
@kazo0 kazo0 self-assigned this Sep 3, 2023
@kazo0 kazo0 added control/shadows and removed triage/untriaged Indicates an issue requires triaging or verification. labels Sep 3, 2023
@kazo0 kazo0 mentioned this issue Sep 3, 2023
Merged
@agneszitte
Copy link
Contributor

Re-Open for backports

@agneszitte agneszitte reopened this Sep 4, 2023
This was linked to pull requests Sep 4, 2023
fix(ShadowContainer): Properly invalidate on shadows collection changed (backport #806) #808
Merged
fix(ShadowContainer): Properly invalidate on shadows collection changed (backport #806) #809
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazo0 kazo0

Labels
control/shadows kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@kazo0 @agneszitte