Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawer Flyout support #203

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Drawer Flyout support #203

merged 1 commit into from
Jul 7, 2022

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Mar 30, 2022 •
edited
Loading

GitHub Issue (If applicable): closes unoplatform/nventive-private#372

PR Type

What kind of change does this PR introduce?

  • Feature

What is the new behavior?

Add FlyoutPresenterStyles that enable gesture support for flyouts.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

The uno.ui version needs to be bumped for Manipulation events to have the proper e.OriginalSource.

Internal Issue (If applicable):

@jeromelaban
Copy link
Member

Can you add a documentation page as well, on how to use this?

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20220329/drawer-flyout branch 2 times, most recently from eefe377 to 1133b41 Compare March 31, 2022 13:27
@github-actions
Copy link

github-actions bot commented Mar 31, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-203.eastus2.azurestaticapps.net

@jeromelaban
Copy link
Member

jeromelaban commented Apr 5, 2022 •
edited by Xiaoy312
Loading

@nickrandolph @francoistanguay
Documentation:
https://github.com/unoplatform/uno.toolkit.ui/blob/dev/xygu/20220329/drawer-flyout/docs/controls/DrawerFlyoutPresenter.md
The API looks fine to me, as it's only a style for an existing flyout, so all the existing interactions apply.

@jeromelaban jeromelaban changed the title Dev/xygu/20220329/drawer flyout Drawer Flyout support Apr 5, 2022
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20220329/drawer-flyout branch 2 times, most recently from 9f59b0b to 3032368 Compare April 7, 2022 18:22
@github-actions
Copy link

github-actions bot commented Apr 7, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-203.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Apr 7, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-203.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20220329/drawer-flyout branch from 3032368 to 75f6363 Compare April 7, 2022 18:29
@Xiaoy312
Copy link
Contributor Author

Xiaoy312 commented Apr 7, 2022 •
edited
Loading

edit: winui compatibility fix & multiline text fix & minor typo fix

@github-actions
Copy link

github-actions bot commented Apr 7, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-203.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 enabled auto-merge (squash) April 12, 2022 17:27
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20220329/drawer-flyout branch from 75f6363 to dc11222 Compare April 12, 2022 17:29
@github-actions
Copy link

github-actions bot commented Apr 12, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-203.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 self-assigned this Jun 27, 2022
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20220329/drawer-flyout branch from dc11222 to 55c9a3c Compare July 7, 2022 04:45
@github-actions
Copy link

github-actions bot commented Jul 7, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-203.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20220329/drawer-flyout branch from 55c9a3c to a5e3845 Compare July 7, 2022 06:21
@github-actions
Copy link

github-actions bot commented Jul 7, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-203.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20220329/drawer-flyout branch from a5e3845 to 6fdd4e4 Compare July 7, 2022 15:52
@github-actions
Copy link

github-actions bot commented Jul 7, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-203.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 merged commit 17c948a into main Jul 7, 2022
@Xiaoy312 Xiaoy312 deleted the dev/xygu/20220329/drawer-flyout branch July 7, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazo0 kazo0 kazo0 left review comments

@jeromelaban jeromelaban jeromelaban approved these changes

@agneszitte agneszitte agneszitte approved these changes

Assignees

@Xiaoy312 Xiaoy312

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Xiaoy312 @jeromelaban @kazo0 @agneszitte