-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nullable types don't get set #10
Comments
Now it supports nullables :) 52dbe86 It probably won't support DateTimeOffset as it's not a primitive, but it's a bit late in my time zone. Have a look at my last commit, it should be easy to add and I would welcome a PR to fix it. |
Got carried away. It was an easy change, now it supports also non-primitive. 5137d07 |
Thanks for the speedy response. I've just raised a PR which adds support for the async query. Could you take a look when you get a chance. I've had issues with the unit test though |
No problem, it may be a while as I may be away next weekend, but thank you for the contribution and I'll merge it in as soon as I can. |
I've got complex objects which have nullable types (ie
int?
,DateTimeOffSet?
). The Moq.Dapper extension for QueryAsync seems to set these all to null instead of their value. I attempted a PR to fix this because I noticed you are restricting the types to non-null types. Adding nullable types just throws an exception in Dapper though.Any ideas?
The text was updated successfully, but these errors were encountered: