Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXPORT_HELPER_ID should start with a null byte when using Rollup #104

Closed
5 tasks done
nielsvanvelzen opened this issue May 11, 2023 · 6 comments · Fixed by #105
Closed
5 tasks done

EXPORT_HELPER_ID should start with a null byte when using Rollup #104

nielsvanvelzen opened this issue May 11, 2023 · 6 comments · Fixed by #105

Comments

@nielsvanvelzen
Copy link
Contributor

Describe the bug

The EXPORT_HELPER_ID doesn't start with a null byte at this moment. This causes issues with Rollup builds using preserveModules.

See also https://rollupjs.org/plugin-development/#conventions

Reproduction

https://rollupjs.org/plugin-development/#conventions

System Info

Irrelevant

Used Package Manager

npm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.
@sxzz
Copy link
Member

sxzz commented May 11, 2023

it will be a small change if you would like to send a PR. :)

@nielsvanvelzen
Copy link
Contributor Author

Sure I can do that, but I'm not sure if that would break other build tools. AFAIK this is a Rollup specific convention.

@sxzz
Copy link
Member

sxzz commented May 11, 2023

Hmmm I think it's ok, if we can pass the unit tests.

@nielsvanvelzen
Copy link
Contributor Author

@sxzz would it be possible to publish a new version with this fix?

@sxzz
Copy link
Member

sxzz commented May 24, 2023

Of course! Will do it today

@sxzz
Copy link
Member

sxzz commented May 24, 2023

Released as v4.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants