New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXPORT_HELPER_ID should start with a null byte when using Rollup #104
Comments
it will be a small change if you would like to send a PR. :) |
Sure I can do that, but I'm not sure if that would break other build tools. AFAIK this is a Rollup specific convention. |
Hmmm I think it's ok, if we can pass the unit tests. |
@sxzz would it be possible to publish a new version with this fix? |
Of course! Will do it today |
Released as v4.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The
EXPORT_HELPER_ID
doesn't start with a null byte at this moment. This causes issues with Rollup builds usingpreserveModules
.See also https://rollupjs.org/plugin-development/#conventions
Reproduction
https://rollupjs.org/plugin-development/#conventions
System Info
Used Package Manager
npm
Validations
The text was updated successfully, but these errors were encountered: