more material param types (vec2,vec3,vec4)

[jice-nospam]

Shouldn't we use directly the tuples MaterialParam::VecN instead of going through a na::VectorN ? (to avoid creating temporary objects and be lighter on garbage collector for the web version)

[edwin0cheng]

• I would prefer na::Vector to tuples, because normally material params are generated by some calculations (e.g. dynamic light direction etc) And it is quite inconvenient to convert them to tuple every single time.
• The compiler should be able to handle it to not create an temp obj, even it create a temp object it should be created in stack. So it should not do any garbage collection both platforms (native or web). And the memory model of wasm do not support GC, that's why Rust is more powerful than other languages for developing wasm. ❤

However, wasm only support some primary types (u32, f32 etc), so passing other object type (struct, enum..) between Js and Wasm, some conventions has to be done.

Stdweb crate handled the conventions by serialize it to json and it is quite slow right now, So after some profiling, i did some optimization on implementation the uniform_matrix_4fv func in webgl crate. It is quite hacky and i don't know we should wait for the stdweb optimization or do it for all webgl functions.
So here are the options:

1. Wait for the optimization of stdweb. (Js! macro performance in wasm32-unknown-unknown koute/stdweb#99)
2. Do all hacky optimization by ourself, just like uniform_matrix_4fv.
3. Keep it what it is, and do the optimization only on the hot path (of cos after profiling)

We do you think ?

[jice-nospam]

Ah indeed. I completely forgot rust kept us from the gc evil :) no problem, let's keep it the current way.

[jice-nospam]

Is there a rust way we can simplify the creation of those params ? Right now, I do it like that :

params.insert("uvSize".to_string(),MaterialParam::Vec2(Vector2::new(1.0,1.0)));

[edwin0cheng]

No right now, but i would make the params as material functions, and im changing the mesh creation code too (For support multiple mesh buffer in single Mesh Component) for wave obj prefab loader.

[edwin0cheng]

And all looks good for me, and i would merge it to master.

[edwin0cheng]

The material api changed, please reference framebuffer/postprocessing api to use it, it should be much easier