Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist folder has outdated url-parse.js file on npm **important** #124

Closed
niftylettuce opened this issue Apr 5, 2018 · 5 comments
Closed

Comments

@niftylettuce
Copy link
Contributor

niftylettuce commented Apr 5, 2018

hello,

can you please run rm -rf dist && npm run browserify and then publish the new version to npm?

the current folder on npm latest release v1.2.0 has these contents:

ls dist
url-parse.js     url-parse.min.js

however the browserify script in package.json only creates url-parse.min.js so I believe url-parse.js is a dev artifact

as far as I can tell, the url-parse.js currently in dist/url-parse.js on npm is outdated

perhaps when doing this you can also update the browserify script to publish both a minified and non-minified version with source maps as well.

once this is done this will close out issues #111 and #112

cc @3rd-Eden

@3rd-Eden
Copy link
Member

3rd-Eden commented Apr 5, 2018

perhaps when doing this you can also update the browserify script to publish both a minified and non-minified version with source maps as well.

yes, I think that will make more sense.

@3rd-Eden
Copy link
Member

3rd-Eden commented Apr 5, 2018

Do you think the referenced commit is a good solution for this problem?

  1. It removes the dist folder to ensure a clean folder on every single publish
  2. It creates a standalone dist/url-parse.js
  3. minifies dist/url-parse.js as dist/url-parse.min.js
  4. creates source map dist/url-parse.min.js.map

@niftylettuce
Copy link
Contributor Author

looks fantastic @3rd-Eden - can you ping me once a new release is up on npm? thanks so much, especially this quick!!! ❤️

@3rd-Eden
Copy link
Member

3rd-Eden commented Apr 6, 2018

Available 1.3.0

@niftylettuce
Copy link
Contributor Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants