-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect handling of protocol-relative URLs in 1.5.x #219
Comments
Should be fixed on master. See d9e332b. Unfortunately I can't publish a new version. |
@lpinca does it make sense for the pathname to be |
@offirgolan that URL is invalid without a base URL. The WHATWG URL parser throws an error for it. The result is consistent with the legacy Node.js URL parser. |
Got it, thanks for the clarification. Do you happen to know how we can get a new release to be published? |
Try to ping @3rd-Eden on Twitter (https://twitter.com/3rdEden). |
I need to figure a way to get stuff autopublished. |
Closing this as I managed to publish this from my windows machine. Note to self: Using linux commands in publish steps is a bad practice. |
Thank you. It still looks a bit weird because > new URL('//github.com')
{
slashes: true,
protocol: '',
hash: '',
query: '',
pathname: '//github.com',
auth: '',
host: '',
port: '',
hostname: '',
password: '',
username: '',
origin: 'null',
href: '//github.com'
} compare to: > new URL('https://github.com')
{
slashes: true,
protocol: 'https:',
hash: '',
query: '',
pathname: '/',
auth: '',
host: 'github.com',
port: '',
hostname: 'github.com',
password: '',
username: '',
origin: 'https://github.com',
href: 'https://github.com/'
} I would have expected that the only differences would be:
but instead there is a difference in Is this intended? |
@krassowski yes this is expected, see @offirgolan comment above. |
results in
////github.com
but it should result in//github.com
.The text was updated successfully, but these errors were encountered: