Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Github Workflow that runs pylint for changed python files #4

Open
jayasimha-raghavan-unskript opened this issue Aug 23, 2022 · 2 comments
Assignees

Comments

@jayasimha-raghavan-unskript
Copy link
Member

Is your feature request related to a problem? Please describe.
The Github Workflow that currently is checked in runs pylint on all python file. This can be improved to run the pylint on changed files only, this would reduce the Github workflow run minutes.

What is to be done?

  • Enhance the existing workflow so it runs pylint on changed py files
  • Make this as the pre-check which should pass to open a Pull Request
@unskript unskript deleted a comment from twishek Oct 2, 2022
@jstjyoti
Copy link

jstjyoti commented Oct 4, 2022

Would pylint run within a docker container or just a script for running pylint is requirement here?

@jayasimha-raghavan-unskript jayasimha-raghavan-unskript changed the title Create a Workflow that runs pylint for all the Python files Create a Github Workflow that runs pylint for changed python files Oct 4, 2022
@jayasimha-raghavan-unskript
Copy link
Member Author

Hello @jstjyoti

Thank you for your interest helping our project.

I have updated the Ticket with More information and modified the Title to reflect what is expected of this ticket.

The Current workflow that is there in .github/workflow folder, does pylint on all the python files. The intention of this ticket was to run the python File on the Changed py files only.

This Gist implements one such approach.
The Linter should be run.

  • As a pre-check for a Pull Request.
  • If the pre-check fails, the pull-request should not be open

Please do let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants