Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it expected to have fields where all values are null #12

Closed
copiousfreetime opened this issue Aug 11, 2020 · 2 comments · Fixed by #16
Closed

Is it expected to have fields where all values are null #12

copiousfreetime opened this issue Aug 11, 2020 · 2 comments · Fixed by #16
Assignees
Labels
bug Something isn't working
Projects

Comments

@copiousfreetime
Copy link
Contributor

When reviewing the data in the lite dataset, all of the following fields are null in all records.

  • unsplash_photos.ai_primary_landmark_name
  • unsplash_photos.ai_primary_landmark_latitude
  • unsplash_photos.ai_primary_landmark_longitude
  • unsplash_photos.ai_primary_landmark_confidence

If all of these are supposed to be null all the time - It may be useful to drop those columns from the dataset completely.

Although if these columns do have data in the full dataset it makes sense to have them exist. If this is the case, it may be useful to update the documentation to note that these fields are null in the lite dataset and have values in the full dataset.

In any case, just checking to make sure that this is the expected behavior.

@copiousfreetime copiousfreetime added the bug Something isn't working label Aug 11, 2020
@lukechesser
Copy link
Member

Tagging in @TimmyCarbone

@TimmyCarbone
Copy link
Member

This is actually a bug. Thank you for catching it, I'll take care of the fix and will bump to 1.0.1.

@TimmyCarbone TimmyCarbone added this to To do in 1.0.1 via automation Aug 11, 2020
1.0.1 automation moved this from To do to Done Aug 12, 2020
@unsplash unsplash locked as resolved and limited conversation to collaborators Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
1.0.1
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants