Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong URL on some photos #46

Closed
peardox opened this issue Jun 13, 2022 · 5 comments · Fixed by #51
Closed

Wrong URL on some photos #46

peardox opened this issue Jun 13, 2022 · 5 comments · Fixed by #51
Labels
bug Something isn't working
Projects
1.2.1

Comments

@peardox
Copy link

peardox commented Jun 13, 2022

Describe the bug
URL is bad

To Reproduce
Try downloading it

Expected behavior
Good URL

Additional context
Add any other context about the problem here.
@peardox peardox added the bug Something isn't working label Jun 13, 2022
@peardox
Copy link
Author

peardox commented Jun 13, 2022

Closed but still broken
photo_image_url ...
https://images.unsplash.company%20by%20Alessandro%20Desantis%20-%20Downloaded%20from%20500px_jpg.jpg

@TimmyCarbone
Copy link
Member

Sorry for the late answer. Thank you for the feedback.

This looks like an edge case. I'm adding this issue to be fixed in the next release.

@TimmyCarbone TimmyCarbone reopened this Aug 30, 2022
@TimmyCarbone TimmyCarbone added this to Needs triage in Triage via automation Aug 30, 2022
@TimmyCarbone
Copy link
Member

Just for reference, some other photos were found with issues in the Full Dataset version:

9_9hzZVjV8s https://images.unsplash.company/%20by%20Alessandro%20Desantis%20-%20Downloaded%20from%20500px_jpg.jpg
VLWy8LIdzsQ https://images.unsplash.com.jpg/
rsJtMXn3p_c https://images.unsplash.com-grass-sun.jpg/
D76DklsG-5U https://images.unsplash.come-home.jpg/
vigsqYux_-8 https://images.unsplash.com_thebeach.jpg/
tCICLJ5ktBE https://images.unsplash.com.jpg/
VLWy8LIdzsQ https://images.unsplash.com.jpg/
rsJtMXn3p_c https://images.unsplash.com-grass-sun.jpg/
D76DklsG-5U https://images.unsplash.come-home.jpg/
vigsqYux_-8 https://images.unsplash.com_thebeach.jpg/
tCICLJ5ktBE https://images.unsplash.com.jpg/

@peardox
Copy link
Author

peardox commented Aug 30, 2022

That looks like it tallies with my reckoning as I have 24,989 valid images out of 25,000

Will the new version have a full 25k (takes ages to download them all)

@TimmyCarbone TimmyCarbone changed the title Photo ID 9_9hzZVjV8s Wrong URL on some photos May 1, 2023
@TimmyCarbone TimmyCarbone removed this from Needs triage in Triage May 1, 2023
@TimmyCarbone TimmyCarbone added this to Done in 1.2.1 May 1, 2023
@TimmyCarbone
Copy link
Member

This is now fixed. Fix will appear in version 1.2.1 that will be released this week.

@TimmyCarbone TimmyCarbone mentioned this issue May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
1.2.1
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 1.2.1 unsplash/datasets
3 participants
@lukechesser @peardox @TimmyCarbone