Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(activity): Activity creation changes #1104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(activity): Activity creation changes #1104

wants to merge 1 commit into from

Conversation

brrkrmn
Copy link
Collaborator

@brrkrmn brrkrmn commented Feb 15, 2024

Summary

This PR addresses the changes needed for the activity creation process. The prioritized tasks were functional needs so the new design is not yet implemented.

Closes #1097

Changes

  1. Created activities are unpublished by default
  2. Removed the 'preview' and 'draft' banner from activity creation form. The 'go back' arrow is also removed since it was not functional.
  3. The label of the submit button in the last step is changed from 'publish' to 'create'
  4. The modal that appears after the user creates an activity is edited:
  • Removed social buttons because the user should not be able to share the activity until it is published
  • Changed the texts to explain that the activity is created and in waitlist to be published.

Screenshots

Screenshot 2024-02-15 at 11 45 34 PM Screenshot 2024-02-16 at 12 01 07 AM Screenshot 2024-02-16 at 12 01 20 AM

@NdibeRaymond
Copy link
Collaborator

still needs rebasing right @brrkrmn ?

NdibeRaymond
NdibeRaymond reviewed Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@NdibeRaymond NdibeRaymond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments

zubhub_frontend/zubhub/src/views/activity_details/ActivityDetailsV2.jsx
<IconButton onClick={toggleDialog}>
<CloseOutlined />
</IconButton>
</div>

<DialogTitle>
<Typography align="center" className={clsx(commonClasses.title2, classes.dialogTitle)}>
Congratulations your Activity has been successfully created!
<Typography align="center" className={classes.dialogTitle}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this @brrkrmn ! seeing untranslated strings stresses me out a lotttttt

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I know @NdibeRaymond , this part was edited in the activity details page PR which uses all text from translation, so I didn't want to redo the work here 😅

zubhub_frontend/zubhub/src/views/create_activity/script.js Outdated
@@ -673,7 +673,7 @@ export const submitForm = async ({ step1Values, step2Values, props, state, handl
const formData = {
...formDataStep1,
...step === 2 ? step2Values : {},
publish: step === 2 ? true : false
publish: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why we are not making it possible for a user to publish an activity immediately it is created?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after discussing this with @tuxology we've come to agree that it should be the staff members who publish activities after making any necessary changes. That's why we now added a whole new tab for unpublished activities for staff members to see. I assume it's because we want activities to be presented in a more monitored and controlled way than projects.

@github-actions GitHub Actions
Copy link

pre-commit checks failed ❌❌❌
make sure you have pre-commit set up locally (see the README.md for instructions).
If you have set up pre-commit locally, you may need to undo this commit and
run "pre-commit" locally to see what the errors are.

@github-actions GitHub Actions
Copy link

pre-commit checks failed ❌❌❌
make sure you have pre-commit set up locally (see the README.md for instructions).
If you have set up pre-commit locally, you may need to undo this commit and
run "pre-commit" locally to see what the errors are.

improve activity created modal
fe58eda 
use translations and change publish button's label to create
remove banner from activity creation form
make created activities unpublished by default
@github-actions GitHub Actions
Copy link

All pre-commit checks passed ✅✅✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NdibeRaymond NdibeRaymond NdibeRaymond left review comments

@tuxology tuxology Awaiting requested review from tuxology tuxology is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(activity): Activity Creation
2 participants
@brrkrmn @NdibeRaymond