Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty manifest files #14

Closed
keeganstreet opened this issue Aug 1, 2023 · 4 comments
Closed

Empty manifest files #14

keeganstreet opened this issue Aug 1, 2023 · 4 comments

Comments

@keeganstreet
Copy link

Hey Hendrik, I'm using @mfng/webpack-rsc in a spike project to try out RSC without Next.js. I think my Webpack config has got the necessary parts from your demo, however when I run a build, the react-client-manifest.json, react-server-manifest.json, and react-ssr-manifest.json files are all empty (they just contain {}). Do you know what I'm doing wrong to prevent the metadata being produced? Here's a reproduction: https://github.com/keeganstreet/rsc-demo

@keeganstreet
Copy link
Author

Actually I have just found the https://github.com/HenriqueLimas/rsc-example repo, which is working. I should be able to compare with that and figure out where I went wrong.

@unstubbable
Copy link
Owner

It seems I need to add an error message for your case, which is that you are not using react-server-dom-webpack/client.browser anywhere. The webpack plugin adds the additional entries for the client references as dependencies to this module. In MFNG, I'm doing this in create-fetch-element-stream.ts which is used in the Router.

@unstubbable
Copy link
Owner

unstubbable commented Aug 1, 2023

@keeganstreet
Copy link
Author

Thanks. That explains it. I hadn't got up to the browser part yet! Still focused on sending the HTML and RSC JSON down the pipe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants