Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twitter benchmark refactoring #149

Closed
ashvardanian opened this issue Oct 14, 2022 · 1 comment · Fixed by #175
Closed

Twitter benchmark refactoring #149

ashvardanian opened this issue Oct 14, 2022 · 1 comment · Fixed by #175
Assignees
@davvard @VioletaStepanyan @Arman-Ghazaryan
Labels
enhancement New feature or request
Milestone
v0.4: Sequenced T...

Comments

@ashvardanian
Copy link
Contributor

  1. Dynamic batch size (as a multiple of copies_per_tweet_k) must be allowed in docs_upsert
  2. The full graph must be imported in the index_file
  3. All insertions must be imported in transactions, to avoid state corruption
@ashvardanian ashvardanian added the enhancement New feature or request label Oct 14, 2022
@ashvardanian ashvardanian added this to the 0.4.0 milestone Oct 14, 2022
@ashvardanian
Copy link
Contributor Author

Fixed by me in 406ca7c.

@ashvardanian ashvardanian linked a pull request Oct 28, 2022 that will close this issue
Fix: Twitter benchmarks use of std::pair #175
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davvard davvard

@VioletaStepanyan VioletaStepanyan

@Arman-Ghazaryan Arman-Ghazaryan

Labels
enhancement New feature or request
Projects
No open projects
UKV Community Edition
Status: Done
Milestone
v0.4: Sequenced Transactions, Parquet...
Development

Successfully merging a pull request may close this issue.

Fix: Twitter benchmarks use of std::pair unum-cloud/ustore
4 participants
@ashvardanian @davvard @VioletaStepanyan @Arman-Ghazaryan