Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assignment 8 #264

Closed
mbonsma opened this issue Oct 23, 2018 · 3 comments
Closed

Assignment 8 #264

mbonsma opened this issue Oct 23, 2018 · 3 comments

Comments

@mbonsma
Copy link
Member

mbonsma commented Oct 23, 2018

The old assignment 7 (before I overwrote it with my assignment) is a good scaffold for what we wanted to include in the last assignment (8):

  • pull requests, forking
  • do stuff with our own temp repository?
  • grade on quality of commit, that they did it, etc.
  • create code of conduct
@James-S-Santangelo
Copy link
Collaborator

This assignment looks really good. I say we go ahead and submit a PR so it can be reviewed. There are a few things we'll need to change (e.g. the master repo is no longer on the UofTCoders GitHub account).

@mbonsma
Copy link
Member Author

mbonsma commented Oct 29, 2018

Sounds good! Do you want to open the PR?

@James-S-Santangelo
Copy link
Collaborator

Sure thing! I'll get to it in the next couple of hours

@mbonsma mbonsma closed this as completed Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbonsma @James-S-Santangelo