Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all viper/cobra dependencies #26

Open
jechols opened this issue Jul 22, 2019 · 1 comment
Open

Remove all viper/cobra dependencies #26

jechols opened this issue Jul 22, 2019 · 1 comment

Comments

@jechols
Copy link
Member

jechols commented Jul 22, 2019

The viper stuff for command-line args is handy, but not worth the half a billion random dependencies it pulls in. Let's figure out a cheaper way to do this. We could parse the toml manually, and probably jam together the ENV and CLI stuff in half a day.

In a very quick test, viper adds 6 megs to a stripped binary, versus about 200k for the toml parser by itself.

@jechols
Copy link
Member Author

jechols commented Sep 20, 2019

This may help: https://www.gmarik.info/blog/2019/12-factor-golang-flag-package/

Looks rudimentary and probably not quite suited to RAIS (no parsing TOML, for instance), but it could be a start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant