How to include only specific services?

[JanC]

Hey 👋
thanks for making this tool!

I have a trace with a lot of services that I'd like to exclude for readability. I thought that by specifying only the services I'm interested in using the include_services would exclude all other services but that does not seem to be the case.

In fact, even in your example config, the v3-service is still present in the diagram even if the config includes only the v1-service and v2-service:

include_services:
  - v1-service
  - v2-service

 ./jigsaw -config config.yaml trace.json
%% Generated by https://github.com/upamune/jigsaw
sequenceDiagram
    v1-service->>v2-service: Ping Request
    v2-service->>v3-service: Pong Request
    v3-service->>v2-service: Pong Response
    v2-service->>v1-service: Ping Response

How could I include only the services I'm interested in?

[JanC]

Here is an example:
trace:

{
    "trace": {
        "spans": {
            "1234567890": {
                "span_id": "1234567890",
                "service": "v1-service",
                "start": 1627781875.00000,
                "parent_id": "0",
                "meta": {
                    "grpc.method.name": "v2-service/1"
                },
                "children_ids": ["1234567892", "1234567893"],
                "type": "rpc"
            },
            "1234567892": {
                "span_id": "1234567892",
                "service": "v2-service",
                "start": 1627781877.00000,
                "meta": {
                    "grpc.method.name": "v3-service/2"
                },
                "type": "rpc"
            },
            "1234567893": {
                "span_id": "1234567893",
                "service": "v3-service",
                "start": 1627781878.00000,
                "meta": {
                    "grpc.method.name": "v4-service/4"
                },
                "type": "rpc"
            }
        }
    }
}

config:

include_services:
  - v1-service
  - v2-service

I'd expect only:

    v1-service->>v2-service: 1 Request
    v2-service->>v3-service: 2 Request
    v3-service->>v2-service: 2 Response
    v2-service->>v1-service: 1 Response

but I get

    v1-service->>v2-service: 1 Request
    v2-service->>v3-service: 2 Request
    v3-service->>v2-service: 2 Response
    v3-service->>v4-service: 4 Request
    v4-service->>v3-service: 4 Response
    v2-service->>v1-service: 1 Response

The exchange between service 3 and 4 should not be present

This condition seems to be always true and hence all the services are included:

jigsaw/diagram.go

Line 124 in 2155cfa

return caller == callee