Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit demo.py for pytest #224

Open
eggplants opened this issue Mar 6, 2022 · 2 comments
Open

Edit demo.py for pytest #224

eggplants opened this issue Mar 6, 2022 · 2 comments

Comments

@eggplants
Copy link
Contributor

eggplants commented Mar 6, 2022

To make testing more easily and measure coverage with pytest-cov, we have to edit demo.py for pytest.

@eggplants
Copy link
Contributor Author

eggplants commented Mar 26, 2022

I would appreciate it if someone could work on this instead of me. Sorry...

@nautics889
Copy link
Contributor

nautics889 commented Mar 17, 2023

I see there are harcoded ID's of Pixiv users, illustrations, etc in demo.py. I'd rather use mock responses from Pixiv for unittest coverage instead of requesting the original Pixiv resource each time while running unittests (pytest).

For now i suggest to create a separate tests.py module and put there pytest functions operating with fixtures and mocked requests. @eggplants, what you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants