Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSM Parameters should support paths in names #441

Closed
stevendborrelli opened this issue Jan 12, 2023 · 4 comments
Closed

SSM Parameters should support paths in names #441

stevendborrelli opened this issue Jan 12, 2023 · 4 comments
Labels
enhancement New feature or request is:triaged Indicates that an issue has been reviewed. stale

Comments

@stevendborrelli
Copy link
Contributor

What problem are you facing?

Currently the AWS SSM parameter resource is using config.NameAsIdentifier, which means that the k8s name is used.

However, it is common in AWS SSM parameters to have path based naming like /abc/xyz/parameter. These kinds of names are not allowed in Kubernetes objects.

https://docs.aws.amazon.com/systems-manager/latest/userguide/sysman-paramstore-su-create.html

How could Official AWS Provider help solve your problem?

Have a spec.forProvider.name to support path based naming.

@stevendborrelli stevendborrelli added the enhancement New feature or request label Jan 12, 2023
@svscheg
Copy link
Contributor

svscheg commented Apr 10, 2023

Need to investigate if we can use some another confirmation for this resource to have a spec.forProvider.name.

@svscheg svscheg added is:triaged Indicates that an issue has been reviewed. and removed needs:triage labels Apr 10, 2023
@stevendborrelli
Copy link
Contributor Author

Please note that a workaround is the use the crossplane.io/external-name annotation to set the path directly. For example:

apiVersion: ssm.aws.upbound.io/v1beta1
kind: Parameter
metadata:
    annotations:
         crossplane.io/external-name: /team1/primaryRegion
spec:
  forProvider:
      dataType: text
      insecureValue: us-east
      region: us-east-1

Copy link

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Apr 20, 2024
Copy link

github-actions bot commented May 9, 2024

This issue is being closed since there has been no activity for 14 days since marking it as stale. If you still need help, feel free to comment or reopen the issue!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request is:triaged Indicates that an issue has been reviewed. stale
Projects
None yet
Development

No branches or pull requests

3 participants