Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump native provider to version 3.80.0 #497

Closed
wants to merge 9 commits into from

Conversation

upbound-bot
Copy link

@upbound-bot upbound-bot commented Jul 19, 2023

Automated changes by create-pull-request GitHub action

In this PR:

  • Native provider version upgraded to 3.80.0
  • The resource HPCCache.storagecache has been made uptesable.
  • Fixed externalname configurations of the following resources:
    • azurerm_web_application_firewall_policy
    • azurerm_api_management_policy
    • azurerm_api_management_api_policy
    • azurerm_api_management_product_policy
    • azurerm_api_management_api_operation_policy
  • The resource WorkspaceRootDbfsCustomerManagedKey has been added.
  • Added reference configurations for WorkspaceCustomerManagedKey.
  • Fixed ApplicationGateway.network example manifest.

Changes made in this PR have been tested uptest and manually, please see comments.

@turkenf
Copy link
Collaborator

turkenf commented Jul 20, 2023

Breaking CRD schema changes

NAME                                                        READY   SYNCED   EXTERNAL-NAME                AGE
resourcegroup.azure.upbound.io/example-flexible-server-pg   True    True     example-flexible-server-pg   12m

NAME                                                                  READY   SYNCED   EXTERNAL-NAME         AGE
flexibleserver.dbforpostgresql.azure.upbound.io/example-turkentetst   True    True     example-turkentetst   5m
NAME                                     READY   SYNCED   EXTERNAL-NAME   AGE
resourcegroup.azure.upbound.io/example   True    True     example         7m45s

NAME                                                             READY   SYNCED   EXTERNAL-NAME   AGE
backuppolicyfileshare.recoveryservices.azure.upbound.io/policy   True    True     policy          7m49s

NAME                                              READY   SYNCED   EXTERNAL-NAME   AGE
vault.recoveryservices.azure.upbound.io/example   True    True     example         7m49s
NAME                                     READY   SYNCED   EXTERNAL-NAME   AGE
resourcegroup.azure.upbound.io/example   True    True     example         15m

NAME                                              READY   SYNCED   EXTERNAL-NAME   AGE
virtualnetwork.network.azure.upbound.io/example   True    True     example         15m

NAME                                      READY   SYNCED   EXTERNAL-NAME   AGE
subnet.network.azure.upbound.io/example   True    True     example         15m

NAME                                             READY   SYNCED   EXTERNAL-NAME   AGE
hpccache.storagecache.azure.upbound.io/example   True    True     example         15m
NAME                                                READY   SYNCED   EXTERNAL-NAME        AGE
resourcegroup.azure.upbound.io/linuxwebappslot-rg   True    True     linuxwebappslot-rg   11m

NAME                                                  READY   SYNCED   EXTERNAL-NAME        AGE
serviceplan.web.azure.upbound.io/linuxwebappslot-sp   True    True     linuxwebappslot-sp   11m

NAME                                                   READY   SYNCED   EXTERNAL-NAME         AGE
linuxwebapp.web.azure.upbound.io/linuxwebappslot-lwa   True    True     linuxwebappslot-lwa   11m

NAME                                                     READY   SYNCED   EXTERNAL-NAME
                                                                                                             AGE
linuxwebappslot.web.azure.upbound.io/lnxappslotexample   True    True     /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/r
esourceGroups/linuxwebappslot-rg/providers/Microsoft.Web/sites/linuxwebappslot-lwa/slots/lnxappslotexample   11m
NAME                                     READY   SYNCED   EXTERNAL-NAME   AGE
resourcegroup.azure.upbound.io/slot-rg   True    True     slot-rg         31m

NAME                                       READY   SYNCED   EXTERNAL-NAME   AGE
serviceplan.web.azure.upbound.io/example   True    True     example         31m

NAME                                                   READY   SYNCED   EXTERNAL-NAME       AGE
windowswebapp.web.azure.upbound.io/windowswebappname   True    True     windowswebappname   31m

NAME                                             READY   SYNCED   EXTERNAL-NAME   AGE
windowswebappslot.web.azure.upbound.io/example   True    True     example         31m

Native schema version changes

  • azurerm_maintenance_assignment_dedicated_host
    Manually:
NAME                                             READY   SYNCED   EXTERNAL-NAME     AGE
resourcegroup.azure.upbound.io/maintenancehost   True    True     maintenancehost   20m

NAME                                                            READY   SYNCED   EXTERNAL-NAME   AGE
maintenanceconfiguration.maintenance.azure.upbound.io/example   True    True     example         20m

NAME                                                                      READY   SYNCED   EXTERNAL-NAME

                                                     AGE
maintenanceassignmentdedicatedhost.maintenance.azure.upbound.io/example   True    True     /subscriptions/038f2b7c-3265-43b8-8
624-c9ad5da610a8/resourceGroups/maintenancehost/providers/Microsoft.Compute/hostGroups/example/hosts/test-fatih/providers/Micr
osoft.Maintenance/configurationAssignments/example   4m10s
  • azurerm_maintenance_assignment_virtual_machine
    Manually:
NAME                                           READY   SYNCED   EXTERNAL-NAME   AGE
resourcegroup.azure.upbound.io/rgmaintenance   True    True     rgmaintenance   14m

NAME                                                   READY   SYNCED   EXTERNAL-NAME   AGE
linuxvirtualmachine.compute.azure.upbound.io/example   True    True     example         14m

NAME                                                                       READY   SYNCED   EXTERNAL-NAME

                                        AGE
maintenanceassignmentvirtualmachine.maintenance.azure.upbound.io/example   True    True     /subscriptions/038f2b7c-3265-43b8-
8624-c9ad5da610a8/resourceGroups/rgmaintenance/providers/Microsoft.Compute/virtualMachines/example/providers/Microsoft.Mainten
ance/configurationAssignments/example   14m

NAME                                                            READY   SYNCED   EXTERNAL-NAME   AGE
maintenanceconfiguration.maintenance.azure.upbound.io/example   True    True     example         14m

NAME                                              READY   SYNCED   EXTERNAL-NAME   AGE
virtualnetwork.network.azure.upbound.io/example   True    True     example         14m

NAME                                      READY   SYNCED   EXTERNAL-NAME   AGE
subnet.network.azure.upbound.io/example   True    True     example         14m

NAME                                                READY   SYNCED   EXTERNAL-NAME   AGE
networkinterface.network.azure.upbound.io/example   True    True     example         14m

Native schema version changes

  • azurerm_storage_account
    Manually:
NAME                                                  READY   SYNCED   EXTERNAL-NAME          AGE
resourcegroup.azure.upbound.io/example-storage-blob   True    True     example-storage-blob   24m

NAME                                           READY   SYNCED   EXTERNAL-NAME   AGE
account.storage.azure.upbound.io/upfatihtest   True    True     upfatihtest     14m

@turkenf turkenf changed the title Bump native provider to version 3.65.0 Bump native provider to version 3.68.0 Aug 4, 2023
@turkenf
Copy link
Collaborator

turkenf commented Aug 7, 2023

/test-examples="examples/automation/hybridrunbookworkergroup.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 7, 2023

/test-examples="examples/dbforpostgresql/flexibleserver-all-in-one.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 7, 2023

/test-examples="examples/network/dnszone.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 7, 2023

/test-examples="examples/recoveryservices/backuppolicyfileshare.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 7, 2023

/test-examples="examples/recoveryservices/backuppolicyvm.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 7, 2023

/test-examples="examples/storage/hpccache.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 7, 2023

/test-examples="examples/recoveryservices/backuppolicyfileshare.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 7, 2023

/test-examples="examples/storage/hpccache.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 7, 2023

/test-examples="examples/web/linuxwebapp.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 7, 2023

/test-examples="examples/web/windowswebapp.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 7, 2023

/test-examples="examples/web/linuxwebappslot.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 7, 2023

/test-examples="examples/web/windowsfunctionappslot.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 7, 2023

/test-examples="examples/network/webapplicationfirewallpolicy.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 7, 2023

/test-examples="examples/storage/accountlocaluser.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 7, 2023

/test-examples="examples/storage/hpccache.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 9, 2023

/test-examples="examples/network/webapplicationfirewallpolicy.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 16, 2023

Uptest for resource azurerm_storage_account fails due to this issue, after filling the relevant parameters, the resource is created successfully.

NAME                                           READY   SYNCED   EXTERNAL-NAME   AGE
account.storage.azure.upbound.io/upfatihtest   True    True     upfatihtest     13m

@turkenf
Copy link
Collaborator

turkenf commented Aug 16, 2023

The import of the azurerm_web_application_firewall_policy resource has changed with the new terraform version, and the uppercase letter of applicationGatewayWebApplicationFirewallPolicies has been replaced with lowercase.
When I update the external name configuration according to this change, I encounter the following error:

    message: "observe failed: cannot run refresh: refresh failed: reading Application
      Gateway Web Application Firewall Policy (Subscription: \"038f2b7c-3265-43b8-8624-c9ad5da610a8\"\nResource
      Group Name: \"webrole-example-ft\"\nApplication Gateway Web Application Firewall
      Policy Name: \"example-ft\"): unexpected status 404 with error: ResourceNotFound:
      The Resource 'Microsoft.Network/applicationGatewayWebApplicationFirewallPolicies/example-ft'
      under resource group 'webrole-example-ft' was not found. For more details please
      go to https://aka.ms/ARMResourceNotFoundFix: "
But when I configure `config.IdentifierFromProvider` the resource is created successfully.

I had the opportunity to discuss this issue with @turkenh and he said that he had encountered a similar issue before. To solve this issue, he opened a PR in Terraform and we need to wait for this PR to continue.

@turkenf turkenf changed the title Bump native provider to version 3.68.0 Bump native provider to version 3.71.0 Aug 29, 2023
@turkenf
Copy link
Collaborator

turkenf commented Aug 29, 2023

/test-examples="examples/network/webapplicationfirewallpolicy.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 29, 2023

After bumping native provider to version 3.71.0

Breaking CRD schema changes

NAME                                                        READY   SYNCED   EXTERNAL-NAME                AGE
resourcegroup.azure.upbound.io/example-flexible-server-pg   True    True     example-flexible-server-pg   4m47s

NAME                                                            READY   SYNCED   EXTERNAL-NAME   AGE
flexibleserver.dbforpostgresql.azure.upbound.io/example-ftest   True    True     example-ftest   4m48s

Native schema version changes

  • azurerm_api_management_api_operation_policy
NAME                                             READY   SYNCED   EXTERNAL-NAME   AGE
api.apimanagement.azure.upbound.io/example-api   True    True     example-api     7m22s

NAME                                                                  READY   SYNCED   EXTERNAL-NAME               AGE
management.apimanagement.azure.upbound.io/uptest-management-example   True    True     uptest-management-example   168m

NAME                                                            READY   SYNCED   EXTERNAL-NAME       AGE
apioperation.apimanagement.azure.upbound.io/acctest-operation   True    True     acctest-operation   7m22s

NAME                                                        READY   SYNCED   EXTERNAL-NAME

                                   AGE
apioperationpolicy.apimanagement.azure.upbound.io/example   True    True     /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a
8/resourceGroups/uptest-resourcegroup-example/providers/Microsoft.ApiManagement/service/uptest-management-example/apis/example-
api/operations/acctest-operation   7m22s
  • azurerm_api_management_api_policy
    Manually:
NAME                                                          READY   SYNCED   EXTERNAL-NAME                  AGE
resourcegroup.azure.upbound.io/uptest-resourcegroup-example   True    True     uptest-resourcegroup-example   4h40m

NAME                                               READY   SYNCED   EXTERNAL-NAME
                                                                                                                       AGE
apipolicy.apimanagement.azure.upbound.io/example   True    True     /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourc
eGroups/uptest-resourcegroup-example/providers/Microsoft.ApiManagement/service/uptest-management-example/apis/my-api   7m50s

NAME                                                                  READY   SYNCED   EXTERNAL-NAME               AGE
management.apimanagement.azure.upbound.io/uptest-management-example   True    True     uptest-management-example   4h40m

NAME                                        READY   SYNCED   EXTERNAL-NAME   AGE
api.apimanagement.azure.upbound.io/my-api   True    True     my-api          116m
  • azurerm_api_management_gateway_api
    Manually:
NAME                                                    READY   SYNCED   EXTERNAL-NAME

                       AGE
gatewayapi.apimanagement.azure.upbound.io/gapiexample   True    True     /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/re
sourceGroups/uptest-resourcegroup-example/providers/Microsoft.ApiManagement/service/uptest-management-example/gateways/gapiexam
ple/apis/gapiexample   9m21s

NAME                                                 READY   SYNCED   EXTERNAL-NAME   AGE
gateway.apimanagement.azure.upbound.io/gapiexample   True    True     gapiexample     9m21s

NAME                                             READY   SYNCED   EXTERNAL-NAME   AGE
api.apimanagement.azure.upbound.io/gapiexample   True    True     gapiexample     9m21s
  • azurerm_api_management_policy
    Manually:
NAME                                                          READY   SYNCED   EXTERNAL-NAME                  AGE
resourcegroup.azure.upbound.io/uptest-resourcegroup-example   True    True     uptest-resourcegroup-example   159m

NAME                                                READY   SYNCED   EXTERNAL-NAME   AGE
namedvalue.apimanagement.azure.upbound.io/example   True    True     example         26m

NAME                                                                  READY   SYNCED   EXTERNAL-NAME               AGE
management.apimanagement.azure.upbound.io/uptest-management-example   True    True     uptest-management-example   159m

NAME                                            READY   SYNCED   EXTERNAL-NAME
                                                                                                        AGE
policy.apimanagement.azure.upbound.io/example   True    True     /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGr
oups/uptest-resourcegroup-example/providers/Microsoft.ApiManagement/service/uptest-management-example   6m22s
  • azurerm_api_management_product_policy
    Manually:
NAME                                                          READY   SYNCED   EXTERNAL-NAME                  AGE
resourcegroup.azure.upbound.io/uptest-resourcegroup-example   True    True     uptest-resourcegroup-example   121m

NAME                                                   READY   SYNCED   EXTERNAL-NAME

    AGE
productpolicy.apimanagement.azure.upbound.io/example   True    True     /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/res
ourceGroups/uptest-resourcegroup-example/providers/Microsoft.ApiManagement/service/uptest-management-example/products/my-produc
t   6m36s

NAME                                                                  READY   SYNCED   EXTERNAL-NAME               AGE
management.apimanagement.azure.upbound.io/uptest-management-example   True    True     uptest-management-example   121m

NAME                                                READY   SYNCED   EXTERNAL-NAME   AGE
product.apimanagement.azure.upbound.io/my-product   True    True     my-product      6m36s
  • azurerm_maintenance_assignment_dedicated_host
    Manually:
NAME                                             READY   SYNCED   EXTERNAL-NAME     AGE
resourcegroup.azure.upbound.io/maintenancehost   True    True     maintenancehost   10m

NAME                                                                      READY   SYNCED   EXTERNAL-NAME

                                                       AGE
maintenanceassignmentdedicatedhost.maintenance.azure.upbound.io/example   True    True     /subscriptions/038f2b7c-3265-43b8-86
24-c9ad5da610a8/resourceGroups/maintenancehost/providers/Microsoft.Compute/hostGroups/test-main/hosts/example-test/providers/Mi
crosoft.Maintenance/configurationAssignments/example   10m

NAME                                                            READY   SYNCED   EXTERNAL-NAME   AGE
maintenanceconfiguration.maintenance.azure.upbound.io/example   True    True     example         10m
  • azurerm_maintenance_assignment_virtual_machine
    Manually:
NAME                                           READY   SYNCED   EXTERNAL-NAME   AGE
resourcegroup.azure.upbound.io/rgmaintenance   True    True     rgmaintenance   14m

NAME                                                   READY   SYNCED   EXTERNAL-NAME   AGE
linuxvirtualmachine.compute.azure.upbound.io/example   True    True     example         14m

NAME                                                                       READY   SYNCED   EXTERNAL-NAME

                                      AGE
maintenanceassignmentvirtualmachine.maintenance.azure.upbound.io/example   True    True     /subscriptions/038f2b7c-3265-43b8-8
624-c9ad5da610a8/resourceGroups/rgmaintenance/providers/Microsoft.Compute/virtualMachines/example/providers/Microsoft.Maintenan
ce/configurationAssignments/example   14m

NAME                                                            READY   SYNCED   EXTERNAL-NAME   AGE
maintenanceconfiguration.maintenance.azure.upbound.io/example   True    True     example         14m

NAME                                      READY   SYNCED   EXTERNAL-NAME   AGE
subnet.network.azure.upbound.io/example   True    True     example         14m

NAME                                                READY   SYNCED   EXTERNAL-NAME   AGE
networkinterface.network.azure.upbound.io/example   True    True     example         14m

NAME                                              READY   SYNCED   EXTERNAL-NAME   AGE
virtualnetwork.network.azure.upbound.io/example   True    True     example         14m

@turkenf
Copy link
Collaborator

turkenf commented Nov 13, 2023

/test-examples="examples/web/windowswebapp.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 13, 2023

/test-examples="examples/web/windowswebappslot.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 13, 2023

/test-examples="examples/storage/accountlocaluser.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 13, 2023

/test-examples="examples/network/webapplicationfirewallpolicy.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 13, 2023

/test-examples="examples/appplatform/springcloudaccelerator.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 13, 2023

/test-examples="examples/appplatform/springcloudcustomizedaccelerator.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 13, 2023

/test-examples="examples/dbforpostgresql/flexibleserver-all-in-one.yaml"

…mple manifest

Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Copy link
Collaborator

turkenf commented Nov 14, 2023

/test-examples="examples/network/applicationgateway.yaml"

Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Copy link
Collaborator

turkenf commented Nov 14, 2023

/test-examples="examples/network/applicationgateway.yaml"

Uptest: https://github.com/upbound/provider-azure/actions/runs/6864993037

@nustiueudinastea
Copy link

Hey folks, sorry to bother you and thanks so much for your efforts! Any chance you can merge this? Much appreciated!

@turkenf turkenf marked this pull request as draft November 28, 2023 13:55
@trois-six
Copy link

Hello, I needed azurerm_cognitive_deployment, so I changed the version of the provider to 3.88.0

diff --git a/Makefile b/Makefile
index 066dfe3e..73c1aadc 100644
--- a/Makefile
+++ b/Makefile
@@ -6,7 +6,7 @@ PROJECT_NAME := provider-$(PROVIDER_NAME)
 PROJECT_REPO := github.com/upbound/$(PROJECT_NAME)
 
 export TERRAFORM_VERSION ?= 1.5.5
-export TERRAFORM_PROVIDER_VERSION ?= 3.57.0
+export TERRAFORM_PROVIDER_VERSION ?= 3.88.0
 export TERRAFORM_PROVIDER_SOURCE ?= hashicorp/azurerm
 export TERRAFORM_PROVIDER_REPO ?= https://github.com/hashicorp/terraform-provider-azurerm
 export TERRAFORM_DOCS_PATH ?= website/docs/r

then added the external name

diff --git a/config/externalname.go b/config/externalname.go
index f5c958f2..01753460 100644
--- a/config/externalname.go
+++ b/config/externalname.go
@@ -184,6 +184,8 @@ var NoForkExternalNameConfigs = map[string]config.ExternalName{
        //
        // /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/group1/providers/Microsoft.CognitiveServices/accounts/account1
        "azurerm_cognitive_account": config.TemplatedStringAsIdentifier("name", "/subscriptions/{{ .setup.configuration.subscription_id }}/resourceGroups/{{ .parameters.resource_group_name }}/providers/Microsoft.CognitiveServices/accounts/{{ .external_name }}"),
+       // /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resourceGroup1/providers/Microsoft.CognitiveServices/accounts/account1/deployments/deployment1
+       "azurerm_cognitive_deployment": config.TemplatedStringAsIdentifier("name", "/subscriptions/{{ .setup.configuration.subscription_id }}/resourceGroups/{{ .parameters.resource_group_name }}/providers/Microsoft.CognitiveServices/accounts/{{ .parameters.cognitive_account_id }}/deployments/{{ .external_name }}"),
 
        // communication
        //

Then regenerated the provider

$ make submodules
$ make generate

It seems to work 😁 (not tested yet), thank you for the hardwork on Upjet, it's magical! It doesn't remove the need for this PR to be refreshed and merged.

@malins
Copy link

malins commented Feb 20, 2024

Hello,
thank you for working on Crossplane, it's a great product.
What is blocking you from merging this PR into main and releasing a new version of the provider?
Thank you!

@jeanduplessis
Copy link
Collaborator

@malins it's simply a case of prioritization at this stage. Bumping the underlying Terraform provider, especially across a large range of releases, requires extensive testing and validation. It is a near-term (next month or two) priority for us to update the TF provider, and since the latest one is on v3.92.0 we will likely not pursue this PR further, but open a new one on the latest TF provider version.

@ulucinar
Copy link
Collaborator

@turkenf & @sergenyalcin have bumped the native provider to ``v3.95.0` in #668.

@ulucinar ulucinar closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants