Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updater-files: Adding entries to the package.json "files" property. #9

Closed
jamen opened this issue Aug 31, 2016 · 4 comments
Closed

Comments

@jamen
Copy link

jamen commented Aug 31, 2016

I don't imagine this should be something too hard, as it is just an array. you could probably just Array.prototype.push.apply(files, input) or something of the like.

I have never made an update plugin before. I could give it a shot if you want.

@jamen jamen changed the title updater-files: Adding files to the package.json "files" property. updater-files: Adding entries to the package.json "files" property. Aug 31, 2016
@doowb
Copy link
Member

doowb commented Aug 31, 2016

@jamen check out normalize-pkg, specifically the files normalizer.

I think some of those things can be split into updaters so they can be used individually (or composed to suit your preferences).

@jonschlinkert
Copy link
Member

Also updater-package does this for common files like index.js

@jonschlinkert
Copy link
Member

doh, it's not published lol. I thought I pushed that one up a long time ago. Give me sec

@jonschlinkert
Copy link
Member

@jamen forgot to update this issue a while back, but updater-package automatically updates the files property.

fwiw @doowb and I have discussed having updaters be more granular, an updater that only updates the files property would still be a great idea. I think the name should probably be something like updater-package-files, so it's clear what it does. If you decide to create this still let us know, I'd love to use it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants