-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: add Argocd application autodiscovery #1911
Comments
Hey, The goal of a autodiscovery is to parse files to gather all information needed to generate Updatecli manifest The Rancher fleet plugin could probably be used as a source of inspiration Then that new plugin would need to be mapped to Updatecli on the following places
Notes that fleet relies on file named |
@olblak I can work on this how can I assign myself? |
More than happy to assign it to you. |
@cloudoutloud have you started this feature yet? |
Otherwise I could pick up something else as there are plenty stuff to improve anyway |
@olblak |
Awesome thanks, then I'll pick something else, enjoy your vacation :) |
Any updates on this? Integration with ArgoCD or a plugin would be greatly appreciated |
I think @cloudoutloud wanted to look into this but I am fine picking up here. |
@olblak |
No need to apologies, don't worry that's totally fine. |
I opened an pullrequest and I am looking for a real argocd git repository containing applications to update :) |
My pullrequest only handles helm version update.
|
Hey @olblak, is there a possibility to specify the keys to upgrade? right now im using multiple sources for some of the apps, also if you got any instructions to test your PR i would be happy to do so, Cheers |
@paltaa you can test the pullrequest by running
do you have more keys than targetRevision to update? |
@paltaa I just released argocd support in https://github.com/updatecli/updatecli/releases/tag/v0.77.0 with docs on https://www.updatecli.io/docs/plugins/autodiscovery/argocd/ |
Hey @olblak i've been testing the plugin with autodiscovery but the PRs are not being created and im not sure why, cant see anything that could point me to the right direction in the logs with debug:
Also what i ment by specifying the keys to update is that in ArgoCD applications you can use multiple sources for the same application, for example (just the
In this case i would like to update Is this supported? Any hints on why the PRs are not created? Cheers |
Mmmh I wasn't aware of |
@olblak Thanks! Let me know when you have something to test |
@paltaa Another pullrequest that you can test. |
@olblak Perfect! Thanks man, will test it right now and comment back |
Alright!
Charts that failed are hosted in private repositories so this should be expected, thanks a lot man! The only doubt that i have now is why the PRs are not being created? am i missing any config? this is the config i have right now: updatecli.d/default.yaml
Also, if i run an apply, the only changes commited to the new branch just have 1 source, only one case for our gitops repo |
You are missing the
should become
|
I am wondering why you have some many skipped pipelines according your run summary
|
Hey @olblak, added your change and the PR is created but still just commits the change for my one chart with one source, any other config needed? Ok, it does not like repoURLs with Also, all of the skipped is the production application that i dont want to automatically update, so that is working fine EDIT: Everything works now Just one last thing, only if possible, can we have 1 pr per dependency? instead of 1 pr for all the upgrades? hehe |
Do you think it it's an issue on Updatecli? Was your manifest initially working? Because I would imagine argocd to fail as well
Yes can set Also combined with |
Great! Thanks for all the help man, really appreciate it.
|
Hey @olblak any date for the release which will contain this new changes? |
What about now? |
Is your feature request related to a problem?
I would like to automatically update the helm charts managed by the Argocd application manifest a
repoURL
sets the upstream chart and thetargetRevision
sets the version number.Solution you'd like
I would like it to look for all files in a repo.
Alternatives you've considered
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: