Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy: The return should be done even if ok fail #205

Merged
merged 1 commit into from
Jun 29, 2018
Merged

copy: The return should be done even if ok fail #205

merged 1 commit into from
Jun 29, 2018

Conversation

otavio
Copy link
Member

@otavio otavio commented Jun 22, 2018

In case of cancellation or a read error, we need to stop the copy. The
condition is wrong as we should return as soon as possible.

Signed-off-by: Otavio Salvador otavio@ossystems.com.br

@coveralls
Copy link

coveralls commented Jun 22, 2018

Coverage Status

Coverage decreased (-0.007%) to 85.358% when pulling a547f27 on otavio:v1-fix-copy-return into 4a8800c on updatehub:v1.

In case of cancellation or a read error, we need to stop the copy. The
condition is wrong as we should return as soon as possible.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
@otavio otavio merged commit 7320d3c into UpdateHub:v1 Jun 29, 2018
@otavio otavio deleted the v1-fix-copy-return branch June 29, 2018 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants