Skip to content
This repository has been archived by the owner on Jul 13, 2021. It is now read-only.

Catch if exit_fail does not contain risk #131

Open
phracek opened this issue Sep 1, 2016 · 3 comments
Open

Catch if exit_fail does not contain risk #131

phracek opened this issue Sep 1, 2016 · 3 comments

Comments

@phracek
Copy link
Contributor

phracek commented Sep 1, 2016

We should be able to detect if module finish with risk and no risk is used.
preupg-xccdf-compose and preupg-create-group-xml scripts should print out some information.

@pirat89
Copy link
Collaborator

pirat89 commented Sep 1, 2016

That doesn't make sense to me. I think that make static analysis of bash + python scripts is overkill.

@AloisMahdal
Copy link
Collaborator

@pirat89 +1

API usage and similar checks could be useful but IMO belong in a dedicated tool -- some kind of "preupg-lint". And I can imagine it requires huge amount of work just to make them barely useful.

Regarding stuff like "risk-less" exit_fail, though, long-term it would be better to work towards getting rid of these "dependencies". (Eg. not require exit_ at all, just infer result from messages/risks.)

@bocekm
Copy link
Collaborator

bocekm commented Aug 30, 2017

PR #218 will handle the "risk-less" exit_fail case - the module result changes from fail to error and a message about that is logged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants