fix(image-shrink): improve icc profile support #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nd0ut
force-pushed
the
fix/shrink-keep-icc
branch
from
38e11e0
to
8c9650c
Compare
homm
reviewed
Feb 11, 2022
homm
reviewed
Feb 11, 2022
homm
requested changes
Mar 24, 2022
src/utils/image-processor.js
Outdated
| ) | ||
| } | ||
|
|
||
| const stripIccProfile = function (file) { |
There was a problem hiding this comment.
Should always return image, original or stripped file
nd0ut
commented
Mar 28, 2022
| function (reason) { | ||
| return $.Deferred().reject(exif, reason) | ||
| () => exif, | ||
| () => $.Deferred().reject(exif) |
There was a problem hiding this comment.
I've removed returning of reason because it isn't used anywhere and it changes the number of arguments here
nd0ut
commented
Mar 28, 2022
| }) | ||
| return op.then( | ||
| () => iccProfile, | ||
| () => $.Deferred().reject(iccProfile) |
nd0ut
commented
Mar 28, 2022
| .then((shouldSkip) => { | ||
| if (shouldSkip) { | ||
| df.reject('skipped') | ||
| return $.Deferred().reject() |
There was a problem hiding this comment.
Fixed code execution after main deferred resolve
nd0ut
commented
Mar 28, 2022
| } | ||
| if (iccProfile?.length > 0) { |
There was a problem hiding this comment.
iccProfile could be undefined in case when getExif was rejected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WDGT-476