Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better management for StatusEntry an related errors #39

Open
ugoamanoh opened this issue Dec 30, 2019 · 1 comment
Open

Better management for StatusEntry an related errors #39

ugoamanoh opened this issue Dec 30, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ugoamanoh
Copy link
Contributor

ugoamanoh commented Dec 30, 2019

accept and use an optional StatusEntry param for checkStatus() to deduplicate parsing of credentials and to support verification of credentials that don't necessarily embed a status entry.

rethink exceptional cases to accommodate credentials that don't embed status, and create more informative errors for misconfigured status methods or malformed entries.

create and use a CredentialStatus implementation that is only used to signal a credential that doesn't declare a status checking method.

@ugoamanoh ugoamanoh added the enhancement New feature or request label Dec 30, 2019
@ugoamanoh ugoamanoh self-assigned this Dec 30, 2019
@ugoamanoh
Copy link
Contributor Author

Implementation Notes

  • return DIDDocument in JWTTools().verify()

  • checkStatus method to allow an optional StatusEntry parameter

  • if StatusEntry is not provided then parse from credential

  • create new CredentialStatus impl call StatusError which can handle error messages

  • if no StatusEntry is supplied or in the credential return StatusError retun an error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant