Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array of either String or Object is difficult to implement in typed languages #50

Open
mirceanis opened this issue Apr 17, 2019 · 0 comments

Comments

@mirceanis
Copy link
Contributor

The verified claims spec is difficult to implement in typed languages.

The verified claims requested from a user. Array of claim types or Claims Specs for self signed claims eg: ["name", {type: "email", essential: true, iss: [{did: 'did:web:uport.claims'}]}]

Having an array of either String or Object is fine in JS but is a nightmare to serialize/deserialize in typed languages.
Not only that, but the logic needed to parse the request gets more complicated and is not necessarily backwards compatible.

Since this is not widespread it may be worth using a different field for the verified claim query in the request instead of complicating the logic of existing fields and breaking current implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant