Skip to content
This repository has been archived by the owner on Feb 1, 2021. It is now read-only.

Provide proguard configuration for android artifacts #29

Open
mirceanis opened this issue Aug 27, 2018 · 0 comments
Open

Provide proguard configuration for android artifacts #29

mirceanis opened this issue Aug 27, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers in progress

Comments

@mirceanis
Copy link
Contributor

mirceanis commented Aug 27, 2018

@mirceanis commented on Thu Jul 19 2018

When integrators use the signer library in an app that uses proguard, they should not have to struggle to find a working proguard configuration for the classes created here, nor one to patch the warnings.

This should be done by providing a consumerProguardFiles entry in signer/build.gradle

Apps may encounter warnings about:
javax.naming.** - because of some unused classes from spongycastle
java.lang.management.** - ??
org.slf4j.** - because of dependencies of kethereum
android.** - ??

definition of done

  • signer demoapp has a release version with minification enabled
  • signer demoapp does NOT need special proguard configuration to use the signer library. It should automatically propagate the proguard config
@mirceanis mirceanis self-assigned this Aug 27, 2018
@mirceanis mirceanis added this to the uPort iis Sprint 4 milestone Aug 27, 2018
@mirceanis mirceanis added enhancement New feature or request good first issue Good for newcomers labels Aug 27, 2018
@mirceanis mirceanis changed the title Provide proguard configuration Provide proguard configuration for signer module Aug 27, 2018
@ozlemulusoy ozlemulusoy modified the milestones: uPort iis Sprint 4, iis Sprint 5 Sep 11, 2018
@mirceanis mirceanis added this to To do in uport-android-sdk Oct 16, 2018
@mirceanis mirceanis changed the title Provide proguard configuration for signer module Provide proguard configuration Oct 8, 2019
@mirceanis mirceanis changed the title Provide proguard configuration Provide proguard configuration for android artifacts Oct 8, 2019
@mirceanis mirceanis removed this from To do in uport-android-sdk Oct 8, 2019
@mirceanis mirceanis removed this from the iis Sprint 5 milestone Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers in progress
Projects
None yet
Development

No branches or pull requests

2 participants