Skip to content

Commit

Permalink
fix: include tx type in eth_signTransaction (#660)
Browse files Browse the repository at this point in the history
* fix(kms-local): eth_signTransaction
* fix(cli): default service type
fixes #641
  • Loading branch information
simonas-notcat committed Aug 11, 2021
1 parent 2f86bf7 commit d45129e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/cli/src/did.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ did
type: 'text',
name: 'type',
message: 'Service type',
default: 'Messaging',
default: 'DIDCommMessaging',
},
{
type: 'text',
Expand Down
2 changes: 1 addition & 1 deletion packages/kms-local/src/key-management-system.ts
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ export class KeyManagementSystem extends AbstractKeyManagementSystem {
* @returns a `0x` prefixed hex string representing the signed raw transaction
*/
private async eth_signTransaction(privateKeyHex: string, rlpTransaction: Uint8Array) {
const { v, r, s, type, ...tx } = parse(rlpTransaction)
const { v, r, s, ...tx } = parse(rlpTransaction)
const wallet = new Wallet(privateKeyHex)
const signedRawTransaction = await wallet.signTransaction(<TransactionRequest>tx)
//HEX encoded string, 0x prefixed
Expand Down

0 comments on commit d45129e

Please sign in to comment.