Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-store): use looser typeorm version range to fix #1013 #1016

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

mirceanis
Copy link
Member

What issue is this PR fixing

fixes #1013

What is being changed

The typeorm version in use was fixed to 0.3.6, disallowing user controlled upgrades to other compatible versions.
This PR bumps typeorm to 0.3.10 and uses a compatibility version range (^0.3.10)

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran yarn, yarn build, yarn test, yarn test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because there is no new functionality.

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #1016 (328a0d5) into main (1268bd2) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1016   +/-   ##
=======================================
  Coverage   80.57%   80.57%           
=======================================
  Files         118      118           
  Lines        4140     4140           
  Branches      919      880   -39     
=======================================
  Hits         3336     3336           
  Misses        801      801           
  Partials        3        3           

@mirceanis mirceanis changed the base branch from main to next October 4, 2022 13:24
@mirceanis mirceanis merged commit 83807f3 into next Oct 4, 2022
@mirceanis mirceanis deleted the 1013-typeorm-fixed-version branch October 4, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug][data-store] typescript 4.8 + typeorm 0.3.6 don't work together
3 participants