Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add eip712 typedDataSigner for ethr #1026

Merged
merged 3 commits into from
Oct 12, 2022

Conversation

fermentfan
Copy link
Contributor

@fermentfan fermentfan commented Oct 11, 2022

Added the _signTypedData to the KMS eth signer to allow EIP712 signing to work.

https://docs.ethers.io/v5/api/signer/#Signer-signTypedData
https://eips.ethereum.org/EIPS/eip-712

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for adding this!

Can you try to rebase your PR on the latest next branch so the tests can run?

@fermentfan
Copy link
Contributor Author

Should be up to date now. Just had to remove some dependabot commit so the merge request looks clean.

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #1026 (1c94e3d) into next (125bf42) will increase coverage by 0.50%.
The diff coverage is 82.20%.

❗ Current head 1c94e3d differs from pull request most recent head c0e59f1. Consider uploading reports for the commit c0e59f1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1026      +/-   ##
==========================================
+ Coverage   80.25%   80.75%   +0.50%     
==========================================
  Files         118      124       +6     
  Lines        4056     4454     +398     
  Branches      875      950      +75     
==========================================
+ Hits         3255     3597     +342     
- Misses        798      854      +56     
  Partials        3        3              

@mirceanis mirceanis merged commit 4371cb9 into decentralized-identity:next Oct 12, 2022
@fermentfan fermentfan deleted the add-eip-712-signer branch October 12, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants