Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated testnets #1028

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

nickreynolds
Copy link
Contributor

What issue is this PR fixing

closes #1025

What is being changed

Replace all uses of rinkeby testnet with goerli (including rinkeby:arbitrum)

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran yarn, yarn build, yarn test, yarn test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because no new functionality is added

Details

Also added slight update to CLI Presentation command to support multiple verifiers

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #1028 (8838436) into next (125bf42) will increase coverage by 0.62%.
The diff coverage is 83.19%.

❗ Current head 8838436 differs from pull request most recent head a8b960b. Consider uploading reports for the commit a8b960b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1028      +/-   ##
==========================================
+ Coverage   80.25%   80.88%   +0.62%     
==========================================
  Files         118      124       +6     
  Lines        4056     4451     +395     
  Branches      875      950      +75     
==========================================
+ Hits         3255     3600     +345     
- Misses        798      848      +50     
  Partials        3        3              

@nickreynolds nickreynolds force-pushed the nickreynolds/remove-deprecated-testnets branch from 12859da to a8b960b Compare October 11, 2022 18:12
@mirceanis mirceanis merged commit 2823738 into next Oct 11, 2022
@mirceanis mirceanis deleted the nickreynolds/remove-deprecated-testnets branch October 11, 2022 18:49
nickreynolds added a commit that referenced this pull request Oct 11, 2022
nickreynolds added a commit that referenced this pull request Oct 11, 2022
nickreynolds added a commit that referenced this pull request Oct 13, 2022
nickreynolds added a commit that referenced this pull request Oct 13, 2022
* feat: migrate Veramo from CommonJS to ESM

* feat: add libp2p didcomm transport and listener node

* fix: remove deprecated testnets (#1028)

fixes #1025

* fix: replace requires with dynamic imports in CLI

* chore: fix veramo versions

Co-authored-by: nickreynolds <nicholas.s.reynolds@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor all uses of Rinkeby and Ropsten testnets to use Goerli
2 participants