First draft of did-pkh method. #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create new pkh-did-provider - Add resolve did-pkh tests - Add create did-pkh identidfier test - Add VC creation/verification using did-pkh identifier Currently not using pkh-did-resolver package (error import). Code momentarily copied to did-provider-pkh resolver.
mirceanis
requested changes
Nov 17, 2022
There was a problem hiding this comment.
Thank you for contributing this and apologies for taking so long to review.
I made some suggestions to fix the failing test.
The DID string for eip155 is formed using the ethereum address, not the compressed public key. This was also the cause of the test failures you were seeing.
Also, CAIP10/eip155 require chainIDs to be used in the blockchainAccountId, not network names.
eip155:1:0xaddress instead of eip155:mainnet:0xaddress
mirceanis
requested changes
Nov 17, 2022
-Use chainId only and not network name -clean up params -fix tests
- Create new pkh-did-provider - Add resolve did-pkh tests - Add create did-pkh identidfier test - Add VC creation/verification using did-pkh identifier Currently not using pkh-did-resolver package (error import). Code momentarily copied to did-provider-pkh resolver.
-Use chainId only and not network name -clean up params -fix tests
Co-authored-by: Mircea Nistor <mirceanis@gmail.com>
Co-authored-by: Mircea Nistor <mirceanis@gmail.com>
Co-authored-by: Mircea Nistor <mirceanis@gmail.com>
dchagastelles
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1052 +/- ##
==========================================
- Coverage 80.25% 79.76% -0.49%
==========================================
Files 118 130 +12
Lines 4056 4699 +643
Branches 875 1011 +136
==========================================
+ Hits 3255 3748 +493
- Misses 798 951 +153
+ Partials 3 0 -3 |
|
now that tests are passing, it would probably be a good time to rebase this branch against |
- Create new pkh-did-provider - Add resolve did-pkh tests - Add create did-pkh identidfier test - Add VC creation/verification using did-pkh identifier Currently not using pkh-did-resolver package (error import). Code momentarily copied to did-provider-pkh resolver.
-Use chainId only and not network name -clean up params -fix tests
- Create new pkh-did-provider - Add resolve did-pkh tests - Add create did-pkh identidfier test - Add VC creation/verification using did-pkh identifier Currently not using pkh-did-resolver package (error import). Code momentarily copied to did-provider-pkh resolver.
-Use chainId only and not network name -clean up params -fix tests
Co-authored-by: Mircea Nistor <mirceanis@gmail.com>
Co-authored-by: Mircea Nistor <mirceanis@gmail.com>
Co-authored-by: Mircea Nistor <mirceanis@gmail.com>
mirceanis
reviewed
Nov 28, 2022
mirceanis
approved these changes
Nov 28, 2022
mirceanis
reviewed
Nov 29, 2022
mirceanis
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new pkh-did-provider
The pkh-did-provider supports only eip155 network id (did:pkh:eip155:...) so for now the network id is hardcoded, but we could easily parameterize to support other networks.
Add resolve did-pkh tests
Tests passing
Add create did-pkh identifier test
Tests passing
Add VC creation/verification using did-pkh identifier
Tests passing
Detail
Currently not using pkh-did-resolver package (error import). Code momentarily copied to did-provider-pkh resolver.
What issue is this PR fixing
Resolves #1024
Quality
Check all that apply:
yarn,yarn build,yarn test,yarn test:browserlocally.