Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(credential-ld): fix LDdefaultContexts file extensions #1086

Merged

Conversation

andyv09
Copy link
Contributor

@andyv09 andyv09 commented Dec 16, 2022

What issue is this PR fixing

Fixes issue where some files without .json suffix cannot be imported and throw Can't resolve error.

What is being changed

Adds .json to filenames that are missing it in ld-default-contexts.ts

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran yarn, yarn build, yarn test, yarn test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #1086 (4f7836e) into next (125bf42) will decrease coverage by 0.50%.
The diff coverage is 77.27%.

❗ Current head 4f7836e differs from pull request most recent head fa1640d. Consider uploading reports for the commit fa1640d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1086      +/-   ##
==========================================
- Coverage   80.25%   79.74%   -0.51%     
==========================================
  Files         118      132      +14     
  Lines        4056     4739     +683     
  Branches      875     1016     +141     
==========================================
+ Hits         3255     3779     +524     
- Misses        798      960     +162     
+ Partials        3        0       -3     

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@mirceanis mirceanis marked this pull request as ready for review December 16, 2022 13:30
@mirceanis mirceanis merged commit 2f57cb1 into decentralized-identity:next Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants