[Action required] Converting Veramo packages from CommonJS to ESM #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 80.25% // Head: 85.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next #1103 +/- ##
==========================================
+ Coverage 80.25% 85.13% +4.88%
==========================================
Files 118 140 +22
Lines 4056 14024 +9968
Branches 875 1422 +547
==========================================
+ Hits 3255 11939 +8684
- Misses 798 2085 +1287
+ Partials 3 0 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mirceanis
force-pushed
the
esm
branch
3 times, most recently
from
9eaa7e2
to
ba3e543
Compare
BREAKING CHANGE: this is a breaking change as modules will have to be loaded differently. test(ci): re-enable coverage reporting on CI chore(ci): fix docs command on ci script test(did-provider-ion): skip a couple of tests that fail with unreasonable errors chore(ci): use ubuntu-latest on CI test: revert some changes in browser tests fix: temporarily remove puppeteer tests fix: partial fix for jest puppeteer fix: progress on test-react-app browser tests fix: use craco for test-react-app to enable babel config test: fix unit and integration tests (browser tests still broken) test: fix most tests for esm fix(build): fix some build issues that prevented tests from working fix: missing deps chore: Migrate esm branch from yarn to pnpm (#1099) chore: wip migrate to pnpm fix: remove schemas fix: pnpm-lock.yaml fix: types in findSigningKeyWithId fix: use requireCjs for importing JSON files fix: use local veramo cli in CI scripts fix: fix api-extractor and schema generation scripts fix: esm objectCreator fix: import / export fix: cors import fix: fix imports in data-store fix: ignore types in schema generation fix: requireCjs fix: broken package.json refactor: convert all modules to ESM. build:js works here
simonas-notcat
approved these changes
Jan 30, 2023
nickreynolds
approved these changes
Jan 30, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this PR fixing
closes #1000
closes #1004
fixes #997
What is being changed
This PR is another go at converting the build outputs to ESM instead of CommonJS.
This is a BREAKING CHANGE, as the
@veramo/*packages will have to be loaded differently.This PR also changes the packager tool from
yarntopnpm.We will be releasing this into the
unstabledist-tag, so you should be able to test this next iteration of Veramo soon by installing all packages as@veramo/*@unstable.This is a major change. We need your feedback!
Quality
Check all that apply:
pnpm i,pnpm build,pnpm test,pnpm test:browserlocally.Details
If applicable, add screen captures, error messages or stack traces to help explain your problem.