Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: isolate core-types package from core #1116

Merged
merged 8 commits into from
Feb 7, 2023
Merged

Conversation

mirceanis
Copy link
Member

@mirceanis mirceanis commented Feb 7, 2023

What issue is this PR fixing

This PR adds the new @veramo/core-types package, which is meant to remove the dependency on core for plugins that only need the type definitions.

The new package contains all the data types that were exported from core.
The same types are also re-exported for convenience so that this is not a breaking change.

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because functionality remains intact.

closes #1115

Copy link
Contributor

@nickreynolds nickreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending tests

@mirceanis mirceanis changed the title feat: separate types package from core feat: isolate core-types package from core Feb 7, 2023
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 84.97% // Head: 84.30% // Decreases project coverage by -0.68% ⚠️

Coverage data is based on head (1ff0551) compared to base (42be48f).
Patch coverage: 54.02% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1116      +/-   ##
==========================================
- Coverage   84.97%   84.30%   -0.68%     
==========================================
  Files         140      142       +2     
  Lines       14050    14060      +10     
  Branches     1428     1431       +3     
==========================================
- Hits        11939    11853      -86     
- Misses       2111     2207      +96     
Impacted Files Coverage Δ
packages/core-types/src/agent.ts 0.00% <0.00%> (ø)
packages/core-types/src/coreEvents.ts 0.00% <ø> (ø)
packages/core-types/src/index.ts 0.00% <0.00%> (ø)
packages/data-store-json/src/types.ts 0.00% <0.00%> (ø)
packages/test-react-app/src/veramo/setup.ts 0.00% <0.00%> (ø)
packages/core/src/agent.ts 99.25% <100.00%> (-0.12%) ⬇️
packages/core/src/index.ts 100.00% <100.00%> (ø)
...es/credential-eip712/src/agent/CredentialEIP712.ts 91.79% <100.00%> (ø)
packages/credential-ld/src/action-handler.ts 88.46% <100.00%> (ø)
packages/credential-ld/src/ld-credential-module.ts 86.01% <100.00%> (ø)
... and 75 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mirceanis mirceanis merged commit ba7a303 into next Feb 7, 2023
@mirceanis mirceanis deleted the nickreynolds/core-types branch February 7, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants