-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: isolate core-types
package from core
#1116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved pending tests
types
package from core
core-types
package from core
Codecov ReportBase: 84.97% // Head: 84.30% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next #1116 +/- ##
==========================================
- Coverage 84.97% 84.30% -0.68%
==========================================
Files 140 142 +2
Lines 14050 14060 +10
Branches 1428 1431 +3
==========================================
- Hits 11939 11853 -86
- Misses 2111 2207 +96
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
What issue is this PR fixing
This PR adds the new
@veramo/core-types
package, which is meant to remove the dependency on core for plugins that only need the type definitions.The new package contains all the data types that were exported from
core
.The same types are also re-exported for convenience so that this is not a breaking change.
Quality
Check all that apply:
pnpm i
,pnpm build
,pnpm test
,pnpm test:browser
locally.closes #1115