Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-types): allow inline @context for Credentials and Presentations #1119

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

mirceanis
Copy link
Member

@mirceanis mirceanis commented Feb 9, 2023

What issue is this PR fixing

fixes #1073

What is being changed

This PR defines a data type for @context properties to include inline objects too, besides strings and string arrays.

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 80.25% // Head: 85.21% // Increases project coverage by +4.96% 🎉

Coverage data is based on head (5e95da9) compared to base (125bf42).
Patch coverage: 82.61% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1119      +/-   ##
==========================================
+ Coverage   80.25%   85.21%   +4.96%     
==========================================
  Files         118      145      +27     
  Lines        4056    14891   +10835     
  Branches      875     1550     +675     
==========================================
+ Hits         3255    12690    +9435     
- Misses        798     2201    +1403     
+ Partials        3        0       -3     
Impacted Files Coverage Δ
packages/core-types/src/coreEvents.ts 100.00% <ø> (ø)
...s/credential-ld/src/module-types/jsonld/index.d.ts 0.00% <0.00%> (ø)
packages/data-store-json/src/types.ts 0.00% <0.00%> (ø)
packages/did-comm/src/message-handler.ts 72.10% <ø> (+12.64%) ⬆️
.../protocols/coordinate-mediation-message-handler.ts 89.63% <ø> (ø)
packages/did-comm/src/protocols/index.ts 100.00% <ø> (ø)
...omm/src/protocols/messagepickup-message-handler.ts 91.25% <ø> (ø)
.../did-comm/src/protocols/routing-message-handler.ts 89.65% <ø> (ø)
...d-comm/src/protocols/trust-ping-message-handler.ts 89.02% <ø> (ø)
packages/did-comm/src/transports/transports.ts 95.23% <ø> (+8.87%) ⬆️
... and 215 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mirceanis mirceanis marked this pull request as ready for review February 21, 2023 18:40
@mirceanis mirceanis merged commit 44bb365 into next Feb 22, 2023
@mirceanis mirceanis deleted the 1073-support-inline-context branch February 22, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@context property of credentials does not support inline documents
2 participants