Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Secp256r1 public keys are losing parity in @veramo/kms-local #1135

Closed
mirceanis opened this issue Feb 24, 2023 · 0 comments · Fixed by #1137
Closed

[bug] Secp256r1 public keys are losing parity in @veramo/kms-local #1135

mirceanis opened this issue Feb 24, 2023 · 0 comments · Fixed by #1137
Labels
bug Something isn't working

Comments

@mirceanis
Copy link
Member

Bug severity
4

Describe the bug

For unknown reasons the parity prefix from Secp256r1 public keys is being removed when creating or importing them:
https://github.com/uport-project/veramo/blob/9c73d98fd217ed9a612767f49a235cdbf43619cb/packages/kms-local/src/key-management-system.ts#L333

This forces broken code to be written. This works only 50% of the time:
https://github.com/uport-project/veramo/blob/0a22d9c2426c69c95263b2f0b36617794b59be62/packages/did-provider-jwk/src/jwkDidUtils.ts#L68

It looks like the fix for this would have to be invoked "manually".

Versions (please complete the following information):

  • Veramo: >=4.1.0 <=5.0.0
@mirceanis mirceanis added the bug Something isn't working label Feb 24, 2023
mirceanis added a commit that referenced this issue Feb 24, 2023
@mirceanis
fix(kms-local): include parity when computing publicKeyHex for P-256 …
06c206a 
…curve

closes #1135
Existing keys still have to be updated manually
mirceanis added a commit that referenced this issue Feb 24, 2023
@mirceanis
fix(did-provider-jwk): use correct parity for P-256 public keys
b62a51a 
closes #1135
Existing keys still have to be updated manually
@mirceanis mirceanis mentioned this issue Feb 24, 2023
Merged
5 tasks
mirceanis added a commit that referenced this issue Feb 24, 2023
@mirceanis
fix(kms-local): include parity when computing publicKeyHex for P-256 …
38ad7e3 
…curve

closes #1135
Existing keys still have to be updated manually
mirceanis added a commit that referenced this issue Feb 24, 2023
@mirceanis
fix(did-provider-jwk): use correct parity for P-256 public keys
22648aa 
closes #1135
Existing keys still have to be updated manually
mirceanis added a commit that referenced this issue Feb 24, 2023
@mirceanis
fix: P256 key parity corrections (#1137)
d0eca2b 
* fix(data-store): decrypt keys before listing in `PrivateKeyStore.listKeys()`
* fix(data-store-json): decrypt before listing in `PrivateKeyStoreJson.listKeys()`
* fix(kms-local): include parity when computing publicKeyHex for P-256 curve; Existing keys still have to be updated manually
* fix(did-provider-jwk): use correct parity for P-256 public keys

fixes #1136
closes #1135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: P256 key parity corrections decentralized-identity/veramo
1 participant
@mirceanis