Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): prevent ExperimentalWarning messages form being printed #1186

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

mirceanis
Copy link
Member

What is being changed

This removes the warnings that appear when working with the CLI after the ESM upgrade

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because we don't have a suitable CLI test suite.

@mirceanis mirceanis marked this pull request as ready for review June 12, 2023 16:16
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e92c596) 84.52% compared to head (7054cb9) 84.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1186   +/-   ##
=======================================
  Coverage   84.52%   84.52%           
=======================================
  Files         158      158           
  Lines       16615    16615           
  Branches     1819     1819           
=======================================
  Hits        14043    14043           
  Misses       2572     2572           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mirceanis mirceanis merged commit a2971aa into next Jun 12, 2023
11 checks passed
@mirceanis mirceanis deleted the cli-warning-fix branch June 12, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants