Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow Secp256r1 key type #1192

Conversation

martines3000
Copy link
Contributor

What is being changed

Allows Secp256r1 key type for verifiable credential and verifiable presentation creation.

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.02 ⚠️

Comparison is base (e2d7966) 84.52% compared to head (55e7e55) 84.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1192      +/-   ##
==========================================
- Coverage   84.52%   84.50%   -0.02%     
==========================================
  Files         158      158              
  Lines       16615    16620       +5     
  Branches     1819     1821       +2     
==========================================
+ Hits        14043    14044       +1     
- Misses       2572     2576       +4     
Impacted Files Coverage Δ
packages/credential-w3c/src/action-handler.ts 81.55% <75.00%> (-0.61%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mirceanis mirceanis changed the base branch from next to main June 27, 2023 17:37
@mirceanis mirceanis changed the base branch from main to next June 27, 2023 17:37
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for adding this!

@mirceanis mirceanis merged commit 2ce7056 into decentralized-identity:next Jun 27, 2023
9 of 11 checks passed
@martines3000 martines3000 deleted the feat/allow-secp256r1-key-type branch June 27, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants