Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): benign change meant to tag all packages for another patch release #1211

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

mirceanis
Copy link
Member

@mirceanis mirceanis commented Aug 3, 2023

We currently use lerna to trigger releases of the @veramo/* packages in tandem. Lerna skips minor or patch releases for packages that don't have changes, even if we instruct it to keep all package versions in sync.

To work around this limitation, this PR adds some irrelevant changes to all the packages so they will get included in the next version bump.

@mirceanis mirceanis changed the title fix(ci): benign change meant to tag all packages for another patch release fix(ci): new patch release Aug 3, 2023
@mirceanis mirceanis changed the base branch from main to next August 4, 2023 10:03
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3cadd56) 84.85% compared to head (ebb1cbe) 84.85%.
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1211   +/-   ##
=======================================
  Coverage   84.85%   84.85%           
=======================================
  Files         167      167           
  Lines       18056    18056           
  Branches     2027     2027           
=======================================
  Hits        15321    15321           
  Misses       2735     2735           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirceanis mirceanis changed the title fix(ci): new patch release fix(ci): benign change meant to tag all packages for another patch release Aug 4, 2023
@mirceanis mirceanis marked this pull request as ready for review August 4, 2023 10:23
@mirceanis mirceanis merged commit 41b5c90 into next Aug 4, 2023
11 checks passed
@mirceanis mirceanis deleted the trigger-release branch August 4, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant