fix(daf-did-jwt): Fix parsing of JWT with missing typ in header
#293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`JwtMessageHandler` can parse them but they fail later in the the message handler chain if `typ` is missing. Also, this fixes #291
mirceanis
force-pushed
the
bugfix/jwt-typ-header
branch
from
2c58921
to
e752d6c
Compare
Codecov Report
@@ Coverage Diff @@
## beta #293 +/- ##
==========================================
- Coverage 68.77% 65.96% -2.82%
==========================================
Files 64 64
Lines 1736 1569 -167
Branches 309 243 -66
==========================================
- Hits 1194 1035 -159
+ Misses 445 438 -7
+ Partials 97 96 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JwtMessageHandlercan parse them but they fail later in the the message handler chain iftypis missing.Also, this fixes #291