Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ethrDID removeKey, removeService #310

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

simonas-notcat
Copy link
Contributor

No unit tests. Tried it out on Rinkeby using CLI - seems to be working fine

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #310 (d9253f7) into beta (7812e51) will decrease coverage by 0.80%.
The diff coverage is 4.54%.

@@            Coverage Diff             @@
##             beta     #310      +/-   ##
==========================================
- Coverage   68.21%   67.41%   -0.81%     
==========================================
  Files          62       62              
  Lines        1504     1522      +18     
  Branches      237      241       +4     
==========================================
  Hits         1026     1026              
- Misses        382      400      +18     
  Partials       96       96              

@mirceanis mirceanis merged commit faccca6 into beta Dec 17, 2020
@mirceanis mirceanis deleted the feature/ethr-did-remove-key-service branch December 17, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants