added did:key provider; fixes #335 #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #351 +/- ##
==========================================
- Coverage 67.58% 66.21% -1.37%
==========================================
Files 62 64 +2
Lines 1530 1560 +30
Branches 247 251 +4
==========================================
- Hits 1034 1033 -1
- Misses 400 426 +26
- Partials 96 101 +5 |
mirceanis
requested changes
Jan 26, 2021
There was a problem hiding this comment.
Nice work!
I flagged some tiny changes that need to be done and it would also be nice to see some tests with this, like checking that a credential issued by a did:key looks ok, or that calling the CRUD methods to modify the DID document throw expected errors.
|
@awoie If you want the provider to be documented you need to add it in here: https://github.com/uport-project/veramo/blob/awoie/did-key/docsconfig.json example doc: http://veramo.io/docs/api/did-provider-ethr.ethrdidprovider |
Co-authored-by: Mircea Nistor <mirceanis@gmail.com>
mirceanis
force-pushed
the
awoie/did-key
branch
from
dc5e4a4
to
3529041
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added did:key provider; fixes #335