-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use URI encoded host in web-did-doc-router #384
fix: use URI encoded host in web-did-doc-router #384
Conversation
Codecov Report
@@ Coverage Diff @@
## next #384 +/- ##
==========================================
- Coverage 67.58% 66.24% -1.34%
==========================================
Files 62 64 +2
Lines 1530 1570 +40
Branches 247 254 +7
==========================================
+ Hits 1034 1040 +6
- Misses 400 428 +28
- Partials 96 102 +6 |
Thank you for the contribution. This depends on how the Also, keep in mind that DIDs such as |
Yeh, it seems like I was to quick to act here :) |
I didn't mean to put a wrench in your machine :) We are fully aware that all the specs we're working against are in flux, so one of the goals of this framework is to be an enabler for quick experimentation, like the proposal you made here. |
BREAKING CHANGES: * `IResolver` interface adapted to core spec * No more `EcdsaSignature` for signers, only `string` output * Signers must accept `Uint8Array` input as well as `string` * Using EcdsaSecp256k1VerificationKey2019 and ...RecoveryMethod2020 * using `verificationMethod` and `blockchainAccountId` from DID documents * deprecated `UniversalResolver` class in favor of `getUniversalResolver` method closes #418 closes #428 closes #417 closes #416 closes #412 closes #397 unblocks #384 fixes #394
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was recently unblocked so it makes sense to merge it now.
Thank you for your contribution!
Closes #383