Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MemoryDIDStore and MemoryKeyStore #447

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

simonas-notcat
Copy link
Contributor

In memory DIDStore for DIDManager and KeyStore for KeyManager. Usefull in situations when DIDs and Keys don't have to be stored in DB and can be imported after agent initialization. For example when using MetaMask as KMS

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #447 (8349ead) into next (0bf7b24) will decrease coverage by 1.29%.
The diff coverage is 70.14%.

❗ Current head 8349ead differs from pull request most recent head dc53b4f. Consider uploading reports for the commit dc53b4f to get more accurate results

@@            Coverage Diff             @@
##             next     #447      +/-   ##
==========================================
- Coverage   67.58%   66.28%   -1.30%     
==========================================
  Files          62       70       +8     
  Lines        1530     1661     +131     
  Branches      247      276      +29     
==========================================
+ Hits         1034     1101      +67     
- Misses        400      454      +54     
- Partials       96      106      +10     

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mirceanis mirceanis merged commit 5ab1792 into next Apr 8, 2021
@mirceanis mirceanis deleted the feature/in-memory-key-did-store branch April 8, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants