add names to entities (so that code on devices succeeds) #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI I realize this PR is lacking in detail, but now that I've resolved the issue I cannot find the original error that showed on the platforms. The tough thing was that all my entity SQL was failing and I got no error toast message so I had to do my own debugging and I guess I didn't save the error messages anywhere. So I'm hoping that this is safe enough to accept, since it simply makes the entity names explicit. If you need me to go back and release a bad version of the app and try to catch the error then... I might work on that, but it'll take a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After deploying in the App & Play Stores, I got an error with the TypeORM code working with these entities. This fixed the problem.