Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return UniqueVerifiableCredential array for getCredentialsForSdr #496

Closed
jasheal opened this issue Apr 29, 2021 · 1 comment · Fixed by #593
Closed

Return UniqueVerifiableCredential array for getCredentialsForSdr #496

jasheal opened this issue Apr 29, 2021 · 1 comment · Fixed by #593
Assignees
@simonas-notcat
Labels
enhancement New feature or request planned-feature don't close this just for being stale

Comments

@jasheal
Copy link

jasheal commented Apr 29, 2021

Update getCredentialsForSdr to use UniqueVerifiableCredential return type
@mirceanis mirceanis added enhancement New feature or request planned-feature don't close this just for being stale incomplete Issue is not well defined. Please ask for clarification before starting to work on it! labels May 13, 2021
@mirceanis
Copy link
Member

@jasonhealy can you provide some more details here, please?

@awoie awoie removed the incomplete Issue is not well defined. Please ask for clarification before starting to work on it! label Jun 28, 2021
@simonas-notcat simonas-notcat self-assigned this Jun 29, 2021
simonas-notcat added a commit that referenced this issue Jun 29, 2021
@simonas-notcat
feat(sdr): returns UniqueVerifiableCredential
ae059b0 
BREAKING CHANGE:
`getVerifiableCredentialsForSdr` and `validatePresentationAgainstSdr`
now returns { hash: string, verifiableCredential: VerifiableCredential}
instead of `VerifiableCredential`

Fixes: #496
@simonas-notcat simonas-notcat mentioned this issue Jun 29, 2021
Merged
mirceanis pushed a commit that referenced this issue Jun 29, 2021
@simonas-notcat
feat(sdr): return UniqueVerifiableCredential for selective-disclosure (…
9c6c090 
…#593)

BREAKING CHANGE: `getVerifiableCredentialsForSdr` and `validatePresentationAgainstSdr` now returns { hash: string, verifiableCredential: VerifiableCredential} instead of `VerifiableCredential`

Fixes: #496
@mirceanis mirceanis mentioned this issue Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonas-notcat simonas-notcat

Labels
enhancement New feature or request planned-feature don't close this just for being stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sdr): returns UniqueVerifiableCredential decentralized-identity/veramo
4 participants
@mirceanis @jasheal @simonas-notcat @awoie