Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SDR CLI and fix local SDR message processing #512

Merged
merged 1 commit into from
May 11, 2021

Conversation

rado0x54
Copy link
Contributor

This fixes #415

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #512 (1025c97) into next (0bf7b24) will increase coverage by 5.31%.
The diff coverage is 81.21%.

@@            Coverage Diff             @@
##             next     #512      +/-   ##
==========================================
+ Coverage   67.58%   72.89%   +5.31%     
==========================================
  Files          62       71       +9     
  Lines        1530     1867     +337     
  Branches      247      322      +75     
==========================================
+ Hits         1034     1361     +327     
- Misses        400      504     +104     
+ Partials       96        2      -94     

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@mirceanis mirceanis merged commit 01cb44e into next May 11, 2021
@mirceanis mirceanis deleted the fix/415_sdr_response branch May 11, 2021 10:41
@mirceanis mirceanis mentioned this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Veramo CLI throws error when creating a SDR response
2 participants