Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secp256k1 key generation is too slow on react-native #549

Closed
mirceanis opened this issue Jun 7, 2021 · 0 comments · Fixed by #551
Closed

secp256k1 key generation is too slow on react-native #549

mirceanis opened this issue Jun 7, 2021 · 0 comments · Fixed by #551
Assignees
@mirceanis
Labels
bug Something isn't working

Comments

@mirceanis
Copy link
Member

mirceanis commented Jun 7, 2021 •
edited
Loading

Bug severity
3

Describe the bug
Since #529 got merged, secp256k1 key generation is very slow on react-native (tested on android).
The culprit seems to be the pbkdf2 method that gets called by @ethersproject/wallet#Wallet.createRandom()
@mirceanis mirceanis added the bug Something isn't working label Jun 7, 2021
@mirceanis mirceanis self-assigned this Jun 7, 2021
mirceanis added a commit that referenced this issue Jun 7, 2021
@mirceanis
fix: speed up secp256k1 keygen
522e3d8 
fixes #549
@mirceanis mirceanis mentioned this issue Jun 7, 2021
Merged
mirceanis added a commit that referenced this issue Jun 7, 2021
@mirceanis
fix: speed up secp256k1 keygen (#551)
75e356c 
fixes #549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirceanis mirceanis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: speed up secp256k1 keygen decentralized-identity/veramo
1 participant
@mirceanis